Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sock_addr tracing bug #2532

Merged

Conversation

saxena-anurag
Copy link
Contributor

Description

This PR fixes a minor bug in the sock_addr tracing where source IP was being printed instead of destination IP.

Testing

CICD

Documentation

NA

@saxena-anurag saxena-anurag marked this pull request as ready for review May 30, 2023 15:48
@saxena-anurag saxena-anurag added the bug Something isn't working label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2532 (e715ff8) into main (b054f0f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
- Coverage   84.18%   84.15%   -0.04%     
==========================================
  Files         157      157              
  Lines       29037    29037              
==========================================
- Hits        24446    24436      -10     
- Misses       4591     4601      +10     
Impacted Files Coverage Δ
netebpfext/net_ebpf_ext_sock_addr.c 83.27% <ø> (ø)

... and 4 files with indirect coverage changes

@saxena-anurag saxena-anurag added this pull request to the merge queue May 30, 2023
Merged via the queue into microsoft:main with commit 3d8f1ad May 30, 2023
@saxena-anurag saxena-anurag deleted the user/anusa/fix_sock_addr_tracing branch May 30, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants