Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel mode stress test - tweak extension stop/restart, better handling of test runtime #2519

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

dv-msft
Copy link
Collaborator

@dv-msft dv-msft commented May 25, 2023

Description

This PR adds some runtime tweaks to fix some non-test-related but intrusive issues. Specifically:

  1. Ignore 'advisory' return status codes from OS/runtime APIs to start/stop NetEbpfExt (i.e., 'driver already stopping/stopped'/'driver start-pending/already started'). These were treated as 'fatal' errors leading to false positives.
  2. Plumb test runtime awareness deeper into long running functions to ensure as timely test termination as possible. Currently, in some cases the actual runtime far exceeded the specified runtime.
  3. Separate out test cases for 'JIT' and 'native' ebpf programs into respective 'test classes'. This now allows us to run 'JIT-only' or 'native-only' tests if required. (Default is still 'all').

Testing

This is test collateral.

Documentation

No documentation changes required.

Fixes #2520

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2519 (f52c41f) into main (396412b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
- Coverage   84.12%   84.08%   -0.04%     
==========================================
  Files         157      157              
  Lines       28978    28978              
==========================================
- Hits        24377    24366      -11     
- Misses       4601     4612      +11     

see 5 files with indirect coverage changes

@dv-msft dv-msft changed the title (DRAFT - NOT FOR REVIEW) - kernel mode stress test - tweak extension stop/restart, better handling of test runtime kernel mode stress test - tweak extension stop/restart, better handling of test runtime May 25, 2023
@dv-msft dv-msft marked this pull request as ready for review May 25, 2023 18:07
@dthaler dthaler added this pull request to the merge queue May 26, 2023
@dthaler dthaler added tests bug Something isn't working labels May 26, 2023
Merged via the queue into microsoft:main with commit b054f0f May 26, 2023
@dv-msft dv-msft deleted the km-stress-tweaks branch June 12, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix kernel mode multi-threaded stress tests to better handle 'advisory' error codes, timely test completion.
3 participants