Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded nuget package #2507

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

Alan-Jowett
Copy link
Member

Resolves: #2471

Description

The eBPF for Windows project doesn't directly depend on boost (only ebpf-verifier does), so removing the package.
Adding ebpf-verifier's copy of the nuget pacakge to the include path.

Testing

CI/CD

Documentation

No.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #2507 (05e52e4) into main (667a948) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   84.06%   84.02%   -0.05%     
==========================================
  Files         155      155              
  Lines       28847    28847              
==========================================
- Hits        24251    24239      -12     
- Misses       4596     4608      +12     

see 3 files with indirect coverage changes

@Alan-Jowett Alan-Jowett added this pull request to the merge queue May 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 24, 2023
@dthaler dthaler added this pull request to the merge queue May 24, 2023
Merged via the queue into microsoft:main with commit f084c9d May 24, 2023
@Alan-Jowett Alan-Jowett deleted the issue2471 branch May 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate copy of boost 1.81
3 participants