Kill test process if it takes more than 5 minutes to execute #2454
Conversation
Signed-off-by: Alan Jowett <[email protected]>
| @@ -22,6 +22,16 @@ Set-Content -Path ($TestProgram + ".fault.log") "" | |||
|
|
|||
| $iteration = 0 | |||
|
|
|||
| $timer = New-Object System.Timers.Timer | |||
| # Set timer for 5 minutes | |||
| $timer.Interval = 300000 | |||
There was a problem hiding this comment.
Is this time value even for fault_injection_full?
Does fault_injection_full take more than 5 mins?
There was a problem hiding this comment.
It shouldn't. Each iteration should take less than 5 minutes unless it's stuck.
There was a problem hiding this comment.
Thanks for clarifying. The reason of ask is, we have more APIs added with fault injection.
Codecov Report
@@ Coverage Diff @@
## main #2454 +/- ##
==========================================
+ Coverage 83.96% 84.03% +0.07%
==========================================
Files 156 156
Lines 29053 29092 +39
==========================================
+ Hits 24393 24447 +54
+ Misses 4660 4645 -15 |
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
scripts/Test-FaultInjection.ps1
Outdated
|
|
||
| # When the watchdog timer fires, kill the test binary. | ||
| Register-ObjectEvent -InputObject $timer -EventName Elapsed -Action { | ||
| Write-Error "Test binary exceede time" |
There was a problem hiding this comment.
Correct spelling: exceeded.
Also, will the user know which binary or test case exceeded the time?
There was a problem hiding this comment.
This should gather a memory dump of the hung process, but that requires some additional work. The first version is to improve the reliability of the CI/CD pipeline.
There was a problem hiding this comment.
Can we have an issue tracking the improvement for the next step?
| @@ -22,6 +22,16 @@ Set-Content -Path ($TestProgram + ".fault.log") "" | |||
|
|
|||
| $iteration = 0 | |||
|
|
|||
| $timer = New-Object System.Timers.Timer | |||
| # Set timer for 5 minutes | |||
| $timer.Interval = 300000 | |||
There was a problem hiding this comment.
Thanks for clarifying. The reason of ask is, we have more APIs added with fault injection.
Co-authored-by: Dave Thaler <[email protected]>
| # Set timer for 5 minutes | ||
| $timer.Interval = 300000 | ||
|
|
||
| # When the watchdog timer fires, kill the test binary. |
There was a problem hiding this comment.
And will this be treated as a pass or a failure?
Description
During fault injection, set a watchdog timer in PS to kill the process if it takes more than 5 minutes to execute.
Testing
CI/CD
Documentation
No.