Fix port_quota app usage #1184
Merged
Fix port_quota app usage #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
requested review from
poornagmsft,
Alan-Jowett,
saxena-anurag and
shankarseal
as code owners
Alan-Jowett
previously approved these changes
Jun 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #1184 +/- ##
=======================================
Coverage 88.13% 88.14%
=======================================
Files 99 99
Lines 17252 17255 +3
=======================================
+ Hits 15205 15209 +4
+ Misses 2047 2046 -1
Continue to review full report at Codecov.
|
saxena-anurag
previously approved these changes
Jun 9, 2022
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
shankarseal
approved these changes
Jun 9, 2022
Alan-Jowett
approved these changes
Jun 9, 2022
Alan-Jowett
added a commit
to Alan-Jowett/ebpf-for-windows
that referenced
this pull request
Jun 10, 2022
* port quota Signed-off-by: Dave Thaler <[email protected]> * Fix port_quota load Signed-off-by: Dave Thaler <[email protected]> Co-authored-by: Alan Jowett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #1132 introduced a regression whereby resolving maps fails. It wasn't caught since the tests used separate buffers for input vs output for ioctls, whereas the real KM path shares the same memory.
This PR fixes the issue and also updates the tests to share the same memory to catch similar issues in the future.
Fixes #1165
Testing
This PR updates tests
Documentation
No changes needed. This makes the flow already documented work again.