Add fuzzer for core helper functions #1153

dthaler · 2022-05-27T21:56:30Z

Description

Add fuzzer for core helper functions

Fixes #620

Testing

This PR adds tests.

Documentation

Updated

codecov · 2022-05-27T22:44:41Z

Codecov Report

Merging #1153 (6b69c4a) into main (25abe8f) will increase coverage by 10.61%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##             main    #1153       +/-   ##
===========================================
+ Coverage   77.57%   88.18%   +10.61%     
===========================================
  Files          91       99        +8     
  Lines       14593    17255     +2662     
===========================================
+ Hits        11321    15217     +3896     
+ Misses       3272     2038     -1234

Impacted Files	Coverage Δ
libs/execution_context/ebpf_maps.c	`89.66% <50.00%> (-0.50%)`	⬇️
libs/platform/user/ebpf_handle_user.c	`76.71% <0.00%> (-17.41%)`	⬇️
libs/platform/ebpf_trampoline.c	`78.48% <0.00%> (-14.25%)`	⬇️
libs/platform/ebpf_object.c	`88.88% <0.00%> (-9.42%)`	⬇️
tests/libs/common/common_tests.cpp	`92.92% <0.00%> (-7.08%)`	⬇️
libs/execution_context/ebpf_core.c	`91.97% <0.00%> (-6.66%)`	⬇️
tests/end_to_end/helpers.h	`91.37% <0.00%> (-6.40%)`	⬇️
libs/ebpfnetsh/links.cpp	`94.73% <0.00%> (-5.27%)`	⬇️
libs/ebpfnetsh/pins.cpp	`95.00% <0.00%> (-5.00%)`	⬇️
libs/ebpfnetsh/maps.cpp	`95.45% <0.00%> (-4.55%)`	⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25abe8f...6b69c4a. Read the comment docs.

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

dthaler · 2022-06-03T16:20:10Z

Filed ossf/scorecard-action#329 to track potential bug in scorecard action resulting in the check failure.

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

.github/workflows/cicd.yml

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

tests/libfuzzer/core_helper_fuzzer/core_helper_fuzzer.vcxproj

Signed-off-by: Dave Thaler <[email protected]> Initial chunk of business logic Signed-off-by: Dave Thaler <[email protected]> More business logic Signed-off-by: Dave Thaler <[email protected]> Add initial helper fuzzer corpus Signed-off-by: Dave Thaler <[email protected]> Fix code analysis warning Signed-off-by: Dave Thaler <[email protected]> Update docs and CI/CD Signed-off-by: Dave Thaler <[email protected]> Update README.md Signed-off-by: Dave Thaler <[email protected]> Fix analysis warning Signed-off-by: Dave Thaler <[email protected]> Add verifier_fuzzer step to github CI/CD Signed-off-by: Dave Thaler <[email protected]> Add core helper and bpf2c fuzzers to CI/CD Signed-off-by: Dave Thaler <[email protected]> Fix fuzzers in CI/CD Signed-off-by: Dave Thaler <[email protected]> Remove changes for other fuzzers from cicd file Signed-off-by: Dave Thaler <[email protected]> Cleanup Signed-off-by: Dave Thaler <[email protected]>

Signed-off-by: Dave Thaler <[email protected]>

* Enable verifier fuzzer in github CI/CD This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]> * Add -artifact_prefix=Artifacts\ Signed-off-by: Dave Thaler <[email protected]> Co-authored-by: Alan Jowett <[email protected]>

dthaler requested review from poornagmsft, Alan-Jowett, saxena-anurag and shankarseal as code owners May 27, 2022 21:56

dthaler marked this pull request as draft May 27, 2022 21:56

dthaler force-pushed the helper-fuzzer branch from 0d87f47 to ecacea0 Compare May 27, 2022 23:41

dthaler changed the title ~~Helper function fuzzer~~ Core helper function fuzzer May 27, 2022

dthaler changed the title ~~Core helper function fuzzer~~ Add fuzz tests for core helper functions May 27, 2022

dthaler mentioned this pull request May 28, 2022

Integrate fuzz testing #620

Closed

3 tasks

dthaler added the tests label May 28, 2022

dthaler marked this pull request as ready for review May 31, 2022 15:13

dthaler force-pushed the helper-fuzzer branch from 7b34a28 to 472a859 Compare May 31, 2022 16:47

dthaler mentioned this pull request May 31, 2022

Part 1 of fuzzer additions #1159

Merged

dthaler added a commit that referenced this pull request Jun 2, 2022

Enable verifier fuzzer in github CI/CD

23b5af4

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

dthaler marked this pull request as draft June 2, 2022 20:45

dthaler mentioned this pull request Jun 2, 2022

Enable verifier fuzzer in github CI/CD #1163

Merged

dthaler force-pushed the helper-fuzzer branch from dedcb38 to 34d11de Compare June 2, 2022 21:16

dthaler changed the title ~~Add fuzz tests for core helper functions~~ Add fuzzer for core helper functions Jun 2, 2022

dthaler force-pushed the helper-fuzzer branch from 34d11de to 861e8d4 Compare June 2, 2022 21:19

dthaler marked this pull request as ready for review June 2, 2022 21:20

dthaler force-pushed the helper-fuzzer branch from 861e8d4 to fc6a5b3 Compare June 6, 2022 17:14

dthaler added a commit that referenced this pull request Jun 6, 2022

Enable verifier fuzzer in github CI/CD

ef5189e

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

dthaler force-pushed the helper-fuzzer branch from fc6a5b3 to 6e55c8b Compare June 6, 2022 17:30

dthaler added the security Related to security hardening label Jun 6, 2022

Alan-Jowett previously approved these changes Jun 7, 2022

View reviewed changes

dthaler added a commit that referenced this pull request Jun 7, 2022

Enable verifier fuzzer in github CI/CD

96087b5

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

dthaler force-pushed the helper-fuzzer branch from 6e55c8b to 20f269d Compare June 7, 2022 22:42

saxena-anurag dismissed Alan-Jowett’s stale review via 20f269d June 8, 2022 02:28

dthaler added a commit that referenced this pull request Jun 8, 2022

Enable verifier fuzzer in github CI/CD

644c908

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

Alan-Jowett reviewed Jun 8, 2022

View reviewed changes

.github/workflows/cicd.yml Outdated Show resolved Hide resolved

dthaler force-pushed the helper-fuzzer branch 2 times, most recently from 49cd613 to 76e8cc5 Compare June 8, 2022 17:05

dthaler requested a review from Alan-Jowett June 8, 2022 17:06

Alan-Jowett previously approved these changes Jun 8, 2022

View reviewed changes

dthaler dismissed Alan-Jowett’s stale review via 37375cb June 9, 2022 17:51

dthaler force-pushed the helper-fuzzer branch 2 times, most recently from 37375cb to 14afe1f Compare June 9, 2022 18:36

dthaler added a commit that referenced this pull request Jun 9, 2022

Enable verifier fuzzer in github CI/CD

3e2ec40

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

dthaler added a commit that referenced this pull request Jun 9, 2022

Enable verifier fuzzer in github CI/CD

ce7e81e

This is another piece split out from PR #1153 Signed-off-by: Dave Thaler <[email protected]>

dthaler force-pushed the helper-fuzzer branch 2 times, most recently from 2326644 to 33e5dae Compare June 9, 2022 20:06

Alan-Jowett previously approved these changes Jun 9, 2022

View reviewed changes

dthaler force-pushed the helper-fuzzer branch from e034dd9 to 0717174 Compare June 9, 2022 22:09

shankarseal reviewed Jun 9, 2022

View reviewed changes

tests/libfuzzer/core_helper_fuzzer/core_helper_fuzzer.vcxproj Show resolved Hide resolved

dthaler dismissed Alan-Jowett’s stale review via 0717174 June 9, 2022 23:17

dthaler added 2 commits June 9, 2022 16:25

Fix bug in _find_lpm_map_entry() hit by fuzzer

6b69c4a

Signed-off-by: Dave Thaler <[email protected]>

dthaler force-pushed the helper-fuzzer branch from 0717174 to 6b69c4a Compare June 9, 2022 23:25

Alan-Jowett approved these changes Jun 10, 2022

View reviewed changes

shankarseal approved these changes Jun 10, 2022

View reviewed changes

Alan-Jowett merged commit 8bc456b into microsoft:main Jun 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fuzzer for core helper functions #1153

Add fuzzer for core helper functions #1153

dthaler commented May 27, 2022 •

edited

Loading

codecov bot commented May 27, 2022 •

edited

Loading

dthaler commented Jun 3, 2022 •

edited

Loading

Add fuzzer for core helper functions #1153

Add fuzzer for core helper functions #1153

Conversation

dthaler commented May 27, 2022 • edited Loading

Description

Testing

Documentation

codecov bot commented May 27, 2022 • edited Loading

Codecov Report

dthaler commented Jun 3, 2022 • edited Loading

dthaler commented May 27, 2022 •

edited

Loading

codecov bot commented May 27, 2022 •

edited

Loading

dthaler commented Jun 3, 2022 •

edited

Loading