Conversation
Member
|
My favorite help is that which occurs without me knowing :P . Glad to hear the JS approach was useful. Looking into the PR now |
davidmrdavid
reviewed
Apr 4, 2022
Member
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
Left some thoughts and questions. Thank you for this PR :-)
sdk/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java
Show resolved
Hide resolved
sdk/src/test/java/com/microsoft/durabletask/ErrorHandlingIntegrationTests.java
Show resolved
Hide resolved
sdk/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java
Show resolved
Hide resolved
sdk/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java
Show resolved
Hide resolved
davidmrdavid
approved these changes
Apr 4, 2022
Member
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
After getting answers to all my comments and questions, this looks good to me :-)
kaibocai
approved these changes
Apr 5, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers the first two bullets of #18: task options and declarative retry policies.
Summary of changes:
TaskOptionsparameter for activities and sub-orchestrationsRetryPolicyclass which can be applied to TaskOptions to configure declarative retries.@Nullableattributes to help proactively identify NullPointerException is the code (I got hit by this a couple times during debugging).Much of the design is inspired by the retry work I recently did for .NET Isolated: microsoft/durabletask-dotnet#6.
Special thanks to @davidmrdavid for helping me figure out (without him knowing it) how to design retries in a language that doesn't support async/await. I borrowed the strategy for implementing retry policies from the Durable JS codebase.
After this PR gets merged, I plan to work on imperative retry policies, implemented in code.