Skip to content

Update protobuf, add suspend and resume event support#97

Merged
jviau merged 5 commits intomicrosoft:mainfrom
jviau:update-protobuf
Jan 10, 2023
Merged

Update protobuf, add suspend and resume event support#97
jviau merged 5 commits intomicrosoft:mainfrom
jviau:update-protobuf

Conversation

@jviau
Copy link
Copy Markdown
Member

@jviau jviau commented Dec 16, 2022 •
edited
Loading

  1. Updates Microsoft.DurableTask.SideCar.Protobuf to 1.0.0
  2. Adds SuspendInstanceAsync and ResumeInstanceAsync to DurableTaskClient.

TODO

  • Add new Suspended state to other locations in the code base.
  • Add unit and integration tests -- NOT DONE - sidecar is not updated with Suspend functionality.

@jviau jviau requested a review from cgillum January 5, 2023 20:32
cgillum
cgillum approved these changes Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open an issue to track adding automated tests for this?

@jviau jviau mentioned this pull request Jan 10, 2023
Closed
@jviau
Copy link
Copy Markdown
Member Author

jviau commented Jan 10, 2023

Opened #108

@jviau jviau merged commit 8efb708 into microsoft:main Jan 10, 2023
@jviau jviau deleted the update-protobuf branch January 10, 2023 21:19
@cgillum cgillum mentioned this pull request Jan 19, 2023
Closed
@jviau jviau mentioned this pull request May 1, 2023
Closed
Copilot AI mentioned this pull request Dec 10, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgillum cgillum cgillum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jviau @cgillum