Skip to content

Fix Anaylzers treating passed in variable argument name as null #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YunchuWang merged 4 commits into from
Feb 17, 2026
Merged

Fix Anaylzers treating passed in variable argument name as null #640

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
565f1df
Fix Anaylzers treating passed in variable argument name as null
YunchuWang Feb 17, 2026
b0f8b33
Update test/Analyzers.Tests/Orchestration/GuidOrchestrationAnalyzerTe…
YunchuWang Feb 17, 2026
b4c2263
Update test/Analyzers.Tests/Orchestration/GuidOrchestrationAnalyzerTe…
YunchuWang Feb 17, 2026
9a845f7
Fix test
YunchuWang Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Analyzers/RoslynExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ public static IEnumerable<MethodDeclarationSyntax> GetSyntaxNodes(this IMethodSy
{
LiteralExpressionSyntax? nameLiteralSyntax = argumentOperation.Syntax.DescendantNodes().OfType<LiteralExpressionSyntax>().FirstOrDefault();

if (nameLiteralSyntax is null)
{
return default;
}

return semanticModel.GetConstantValue(nameLiteralSyntax, cancellationToken);
}

Expand Down
40 changes: 40 additions & 0 deletions test/Analyzers.Tests/Orchestration/DateTimeOrchestrationAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,46 @@ public async Task FuncOrchestratorWithLambdaHasDiag()
await VerifyCS.VerifyDurableTaskCodeFixAsync(code, expected, fix);
}

[Fact]
public async Task FuncOrchestratorInForEachWithVariableNameNoDiag()
{
string code = Wrapper.WrapFuncOrchestrator(@"
string[] names = new[] { ""A"", ""B"" };
foreach (string name in names)
{
tasks.AddOrchestratorFunc<string, string>(
name,
async (ctx, input) =>
{
return await ctx.CallActivityAsync<string>(""Activity"", input);
});
}
");

await VerifyCS.VerifyDurableTaskAnalyzerAsync(code);
}

[Fact]
public async Task FuncOrchestratorInForEachWithVariableNameHasDiag()
{
string code = Wrapper.WrapFuncOrchestrator(@"
string[] names = new[] { ""A"", ""B"" };
foreach (string name in names)
{
tasks.AddOrchestratorFunc(
name,
context =>
{
return {|#0:DateTime.Now|};
});
}
");

DiagnosticResult expected = BuildDiagnostic().WithLocation(0).WithArguments("Main", "System.DateTime.Now", "Main");

await VerifyCS.VerifyDurableTaskAnalyzerAsync(code, expected);
}

[Fact]
public async Task FuncOrchestratorWithMethodReferenceHasDiag()
{
Expand Down
40 changes: 40 additions & 0 deletions test/Analyzers.Tests/Orchestration/DelayOrchestrationAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,46 @@ public async Task FuncOrchestratorUsingThreadSleepHasDiag()
await VerifyCS.VerifyDurableTaskAnalyzerAsync(code, expected);
}

[Fact]
public async Task FuncOrchestratorInForEachWithVariableNameNoDiag()
{
string code = Wrapper.WrapFuncOrchestrator(@"
string[] names = new[] { ""A"", ""B"" };
foreach (string name in names)
{
tasks.AddOrchestratorFunc<string, string>(
name,
async (ctx, input) =>
{
return await ctx.CallActivityAsync<string>(""Activity"", input);
});
}
");

await VerifyCS.VerifyDurableTaskAnalyzerAsync(code);
}

[Fact]
public async Task FuncOrchestratorInForEachWithVariableNameHasDiag()
{
string code = Wrapper.WrapFuncOrchestrator(@"
string[] names = new[] { ""A"", ""B"" };
foreach (string name in names)
{
tasks.AddOrchestratorFunc(
name,
context =>
{
{|#0:Thread.Sleep(1000)|};
});
}
");

DiagnosticResult expected = BuildDiagnostic().WithLocation(0).WithArguments("Main", "Thread.Sleep(int)", "Main");

await VerifyCS.VerifyDurableTaskAnalyzerAsync(code, expected);
}

static DiagnosticResult BuildDiagnostic()
{
return VerifyCS.Diagnostic(DelayOrchestrationAnalyzer.DiagnosticId);
Expand Down
39 changes: 39 additions & 0 deletions test/Analyzers.Tests/Orchestration/GuidOrchestrationAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,45 @@ public async Task FuncOrchestratorUsingNewGuidHasDiag()
await VerifyCS.VerifyDurableTaskCodeFixAsync(code, expected, fix);
}

[Fact]
public async Task FuncOrchestratorInForEachWithVariableNameNoDiag()
{
string code = Wrapper.WrapFuncOrchestrator(@"
string[] names = new[] { ""A"", ""B"" };
foreach (string name in names)
{
tasks.AddOrchestratorFunc<string, string>(
name,
async (ctx, input) =>
{
return await ctx.CallActivityAsync<string>(""Activity"", input);
});
}
");

await VerifyCS.VerifyDurableTaskAnalyzerAsync(code);
}

Comment thread
YunchuWang marked this conversation as resolved.
[Fact]
public async Task FuncOrchestratorInForEachWithVariableNameHasDiag()
{
string code = Wrapper.WrapFuncOrchestrator(@"
string[] names = new[] { ""A"", ""B"" };
foreach (string name in names)
{
tasks.AddOrchestratorFunc<string, string>(
name,
async (ctx, input) =>
{
return {|#0:Guid.NewGuid()|};
});
}
");

DiagnosticResult expected = BuildDiagnostic().WithLocation(0).WithArguments("Main", "Guid.NewGuid()", "Main");

await VerifyCS.VerifyDurableTaskAnalyzerAsync(code, expected);
}
static DiagnosticResult BuildDiagnostic()
{
return VerifyCS.Diagnostic(GuidOrchestrationAnalyzer.DiagnosticId);
Expand Down
Loading