Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the WebAPI sample from the repository as it lacks a server-side gRPC sidecar implementation that would be required to make it functional. Customers are directed to use alternative samples in the Azure-Samples/Durable-Task-Scheduler repository instead.
Key Changes:
- Removal of the entire WebAPI sample project including source code, configuration files, and Docker deployment files
- Removal of WebAPI project reference from the solution file
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.DurableTask.sln | Removes WebAPI project entry from solution (incomplete - see comment) |
| samples/WebAPI/Program.cs | Deletes main program file with DurableTask configuration |
| samples/WebAPI/WebAPI.csproj | Deletes project file |
| samples/WebAPI/Controllers/OrderProcessingController.cs | Deletes controller for order processing endpoints |
| samples/WebAPI/Orchestrations/ProcessOrderOrchestrator.cs | Deletes orchestrator implementation |
| samples/WebAPI/Orchestrations/CheckInventoryActivity.cs | Deletes activity implementation |
| samples/WebAPI/Orchestrations/ChargeCustomerActivity.cs | Deletes activity implementation |
| samples/WebAPI/Orchestrations/CreateShipmentActivity.cs | Deletes activity implementation |
| samples/WebAPI/Models/OrderInfo.cs | Deletes model definition |
| samples/WebAPI/Models/OrderStatus.cs | Deletes model definition |
| samples/WebAPI/Models/ApprovalEvent.cs | Deletes model definition |
| samples/WebAPI/appsettings.json | Deletes configuration file |
| samples/WebAPI/appsettings.Development.json | Deletes development configuration file |
| samples/WebAPI/Properties/launchSettings.json | Deletes launch settings |
| samples/WebAPI/Dockerfile | Deletes Docker build configuration |
| samples/WebAPI/.dockerignore | Deletes Docker ignore file |
| samples/WebAPI/demo-deployment.yaml | Deletes Kubernetes deployment manifest |
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "WebAPI", "samples\WebAPI\WebAPI.csproj", "{21AF0D71-6D32-483F-B6E8-3B28EE432560}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Shared", "src\Shared\Shared.csproj", "{57A4C812-B0D9-49E9-9EBE-7E94D3D78ED7}" |
There was a problem hiding this comment.
Incomplete removal of WebAPI project from solution file. While the Project declaration has been removed, the build configuration entries (lines 176-179) and nested project assignment (line 298) for the WebAPI project GUID {21AF0D71-6D32-483F-B6E8-3B28EE432560} still remain in the GlobalSection blocks. These orphaned entries should also be removed to prevent build warnings or errors.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
* Initial plan * Remove orphaned WebAPI project entries from solution file Co-authored-by: torosent <17064840+torosent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
In order for the WebAPI sample to work a server-side implementation for the gRPC sidecar service would need to be added to the service collection, but that would involve introducing external dependencies that aren't appropriate for this repo.
We have samples for the standalone SDK with the DTS backend (the DTS backend implements the server-side logic for the gRPC sidecar service that is missing in the WebAPI sample). Customers can reference these instead.
This PR removes this sample entirely since it is not instructive for customers.