Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Authentication configuration guide #220

Merged

Conversation

michaelstonis
Copy link
Contributor

Provides a guide for configuring authentication in the API services.

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one comment so I'll proactively approve.

"TenantId": "{AZURE_AD_TENANT_ID}",
"ClientId": "{AZURE_AD_CLIENT_ID}"
},
"Authentication": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to remove this config section and show that it gets populated after the user runs dotnet user-jwts below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@captainsafia, just the Authentication section, correct? I can update the docs to explain this as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Just the authentication section needs to be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelstonis any update on this?

@jamesmontemagno jamesmontemagno merged commit 5cd9f5d into microsoft:main Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants