-
Notifications
You must be signed in to change notification settings - Fork 346
Move new windows release issue template from dotnet/release #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MichaelSimons
merged 2 commits into
microsoft:main
from
MichaelSimons:new-os-issue-template
Jul 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| --- | ||
| name: ".NET Framework Docker Release - New Windows Version" | ||
| about: "Checklist for releasing .NET Framework container images for new Windows major versions" | ||
| title: ".NET Framework Container Images Release - New Windows Version - <new Windows version>" | ||
| labels: docker | ||
| assignees: lbussell | ||
| --- | ||
|
|
||
| ## Prep Tasks | ||
|
|
||
| 1. - [ ] Ensure a ["New Windows Release" issue](https://github.com/dotnet/docker-tools/blob/.github/ISSUE_TEMPLATE/releases/new-windows-release.md) exists for docker-tools repo | ||
| 1. - [ ] Update [manifest.json](https://github.com/microsoft/dotnet-framework-docker/blob/main/manifest.json) to include entries for the new images | ||
| 1. - [ ] Update [manifest.samples.json](https://github.com/microsoft/dotnet-framework-docker/blob/main/manifest.samples.json) to include the new Windows version for each of the samples | ||
| 1. - [ ] Update the test data for each of the [test classes](https://github.com/microsoft/dotnet-framework-docker/tree/main/tests/Microsoft.DotNet.Framework.Docker.Tests) to include the new Windows version | ||
| 1. - [ ] Run the `update-dependencies` tool to generate the new Dockerfiles and update all the necessary files: | ||
| - [ ] `dotnet run --project .\eng\update-dependencies` | ||
| 1. - [ ] Inspect generated changes for correctness | ||
| 1. - [ ] Test the images | ||
| 1. - [ ] Create a local VM of the new Windows version | ||
| 1. - [ ] Clone this repo with the above changes onto the VM | ||
| 1. - [ ] Run `.\build-and-test.ps1 -OS windowsservercore-<VERSION>` to build and test your changes | ||
| 1. - [ ] Revert any modifications that were made to the 3.5/runtime Dockerfile to support local testing due to the lack of the https://dotnetbinaries.blob.core.windows.net/dockerassets/microsoft-windows.netfx3-<VERSION>.zip file. | ||
| 1. - [ ] Commit generated changes | ||
| 1. - [ ] Create PR | ||
| 1. - [ ] Get PR signoff. **Don't merge PR to main.** | ||
|
|
||
| ## Release Day Tasks | ||
|
|
||
| 1. - [ ] Create a [`microsoft-windows.netfx3-<VERSION>.zip](https://github.com/microsoft/dotnet-framework-docker/blob/1c3dd6638c6b827b81ffb13386b924f6dcdee533/3.5/runtime/windowsservercore-1909/Dockerfile#L11) file containing the .NET Fx 3.5 cab installer file and upload it to the [blob storage location](https://dotnetbinaries.blob.core.windows.net/dockerassets). | ||
| 1. - [ ] Follow [Patch Tuesday release](patch-tuesday-release.md) process | ||
| 1. - [ ] Create an announcement (example: [Windows Server, version 1909](https://github.com/microsoft/dotnet-framework-docker/issues/448)) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.