Skip to content

Conversation

@Kanchan-Microsoft
Copy link
Contributor

Purpose

This pull request updates the resource group tags handling in the infrastructure templates to ensure that tags from the resource group are merged with existing tags when deploying resources. Additionally, it corrects the order of dependencies in the generated ARM template.

Tag merging improvements:

  • Updated the resourceGroupTags resource in main.bicep to merge the current resource group's tags with custom tags, ensuring all relevant tags are applied to resources.
  • Modified the tags property in the generated main.json ARM template to include resourceGroup().tags in the merge operation, aligning the JSON output with the Bicep source.

Template and dependency updates:

  • Updated the templateHash in main.json to reflect the changes in the template.
  • Fixed the order of dependencies in the dependsOn array for private DNS zones in main.json to maintain consistency and correctness.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Kanchan-Microsoft Kanchan-Microsoft changed the title fix: Prevent removal of existing RG tags fix: Prevent removal of existing RG tags when deploying GSA Oct 28, 2025
@Prajwal-Microsoft Prajwal-Microsoft merged commit 311ad73 into dev Oct 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants