Skip to content

Conversation

flying-sheep
Copy link

@flying-sheep flying-sheep commented Sep 28, 2025

Fixes #1959

TODO:

  • are the tests in src/debugpy/_vendored/pydevd/tests_python/ run at all?
  • maybe needs changes because User{Dict,List} also have a field
  • add tests for KeysView/ValuesView

@flying-sheep flying-sheep requested a review from a team as a code owner September 28, 2025 13:36
@flying-sheep flying-sheep marked this pull request as draft September 28, 2025 13:37
from _pydevd_bundle.pydevd_resolver import get_var_scope, MoreItems, MoreItemsRange
from typing import Optional

try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is still required for pre 3.11? There is no FrameType in 3.10.

@rchiodo
Copy link
Contributor

rchiodo commented Sep 29, 2025

are the tests in src/debugpy/_vendored/pydevd/tests_python/ run at all?

They're not run as part of the normal PR process, well because changes to Pydevd should generally be made upstream first. This hasn't been happening lately though. I usually run the Pydevd tests manually myself.

@rchiodo
Copy link
Contributor

rchiodo commented Sep 29, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rchiodo
Copy link
Contributor

rchiodo commented Sep 29, 2025

The directions here should outline how to run the Pydevd tests:

https://github.com/microsoft/debugpy/blob/main/CONTRIBUTING.md#updating-pydevd

@flying-sheep
Copy link
Author

so they aren’t run by your CI?

other question: are any failures here related to my change?

@rchiodo
Copy link
Contributor

rchiodo commented Sep 30, 2025

so they aren’t run by your CI?

No they're not. You have to run them manually.

other question: are any failures here related to my change?

I don't believe so. There's something going on with thread_count at the moment. Not sure what, but there's been intermittent failures with that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fundamental types to resolvers

2 participants