Skip to content

Use subrepo to link to PyDev.Debugger instead of copying it #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Use subrepo to link to PyDev.Debugger instead of copying it #1714

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7b94f64
Remove copy of pydevd and add subrepo script
rchiodo Oct 23, 2024
54f4003
git subrepo clone https://github.com/fabioz/PyDev.Debugger.git src/de…
rchiodo Oct 23, 2024
942a227
Add binskim settings to match debugpy
rchiodo Oct 23, 2024
6a447b7
git subrepo clone --force https://github.com/fabioz/PyDev.Debugger.gi…
rchiodo Oct 28, 2024
45b2de7
Remove unnecessary string test by removing the lambda in pydevd_sys_m…
rchiodo Oct 29, 2024
a7f600d
Fix linter
rchiodo Oct 29, 2024
bc98d3e
Put back the fix in qt_loaders
rchiodo Oct 29, 2024
cb00c00
Put back binskim flag
rchiodo Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/debugpy/_vendored/pydevd/pydevd_attach_to_process/windows/compile_windows.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ cl -DUNICODE -D_UNICODE /EHsc /Zi /O1 /W3 /LD /MD /D BITS_32 /Qspectre run_code_
copy run_code_on_dllmain_x86.dll ..\run_code_on_dllmain_x86.dll /Y
copy run_code_on_dllmain_x86.pdb ..\run_code_on_dllmain_x86.pdb /Y

cl /EHsc /Zi /O1 /W3 /Qspectre inject_dll.cpp /link /PROFILE /GUARD:CF /out:inject_dll_x86.exe
cl /EHsc /Zi /O1 /W3 /Qspectre inject_dll.cpp /link /PROFILE /GUARD:CF /CETCOMPAT /out:inject_dll_x86.exe
Copy link
Contributor

@AdamYoblick AdamYoblick Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we have to fix these compiler and linker flags up every time we pull from PyDev.Debugger, or are we trying to push these changes back to him?

Copy link
Contributor Author

@rchiodo rchiodo Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to push this back to him now

Copy link
Contributor Author

@rchiodo rchiodo Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had made these changes there but missed a spot, this is my changes coming back

copy inject_dll_x86.exe ..\inject_dll_x86.exe /Y
copy inject_dll_x86.pdb ..\inject_dll_x86.pdb /Y

Expand Down
Loading