Repository navigation
[release/0.26] Harden watcher consumption and adopt bounded Tilt watch delivery - #307
Merged
Merged
Conversation
Mitch Denny (mitchdenny)
approved these changes
Oct 19, 2026
David Negstad (danegsta)
enabled auto-merge (squash)
October 19, 2026 22:59
This was referenced Oct 23, 2026
This was referenced Oct 26, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #292 to
release/0.26to prevent unread watches from stalling API storage publication and unrelated watcher shutdown.Keep the V2 Namespace lifecycle watch draining during snapshot requests and shutdown, initialize LogStorage's disposal signal, and avoid allocating per-resource watchers when parent-watch setup fails. Upgrade tilt-apiserver from v0.19.1 to v0.19.2 for bounded, asynchronous watcher delivery, with matching checksums and dependency notice updates.
Backport scope
Cherry-pick the final merged change from
06562f36aa9361e4f58db10626f9f9aac5cdb8b2relative to its first parent, rather than mergingmainor replaying the source branch's intermediate commits. The patch applied cleanly: all five changed Go files match the merged source PR exactly, while the release branch's separate dependency entries and notices are preserved. No unrelated release/0.27 feature work is included.Include the source regression tests and remove the test that depends on the superseded synchronous watch-publication stall. Aspire scaffolding fixes are already present on the target branch through #303 and are not part of this diff.
Related to #286; this backport does not claim the original Aspire CI scenario has been reproduced or verified.
Validation
make test-prereqsCGO_ENABLED=1 go test -race -count 1 -parallel 32 -timeout 180s -overlay=.toolbin/go-runtime-overlay/overlay.json ./api/v1 ./internal/apiserver)make test(full unit/integration suite)make generate(no generated content changes)make lintgo mod verifyAll checks passed on macOS. Aspire E2E validation is left to CI.