Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub action LLVM version to 17.0.5 #1373

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

jonwis
Copy link
Member

@jonwis jonwis commented Nov 25, 2023

In #1372 it looks like the build VMs were updated to a more recent VS and VCRT and STL combination, requiring an updated LLVM toolchain. This bumps the target LLM version to match.

@jonwis jonwis changed the title Maybe update tools version Update GitHub action LLVM version to 17.0.5 Nov 25, 2023
@jonwis
Copy link
Member Author

jonwis commented Nov 25, 2023

A new and interesting errro!

@jonwis
Copy link
Member Author

jonwis commented Nov 25, 2023

Turns out that LLVM 17.0.5 resolved this complaint:

#if defined(__clang__) && defined(_MSC_VER)
// FIXME: Blocked on __cpp_consteval, see:
// * https://github.com/microsoft/cppwinrt/pull/1203#issuecomment-1279764927
// * https://github.com/llvm/llvm-project/issues/57094
TEST_CASE("custom_error_logger", "[!shouldfail]")

... so the test metadata needs to be updated to say that clang is no longer "!shouldfail"

@jonwis
Copy link
Member Author

jonwis commented Nov 25, 2023

Notably, the test_component component does not build correctly here:

msbuild /m /p:Configuration=Debug,Platform=x64,Clang=1,LLVMToolsVersion=17.0.5,LLVMInstallDir=C:\llvm cppwinrt.sln

At least on my machine, the test_component.vcxproj picks up C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\Llvm\x64\bin\clang-cl.exe ... everything else correctly picks up the $(SolutionRootDir).llvm path. This causes a series of errors in yvals_core.h due to undefined uintptr_t

A problem for another day.

@jonwis jonwis merged commit 912aa47 into microsoft:master Nov 26, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants