Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed visibility of observable_map_base::call_changed to protected #1425

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Patschkowski
Copy link
Contributor

@Patschkowski Patschkowski commented Jul 10, 2024

This matches the visibility of observable_vector_base::call_changed to enable derived classes to raise change notifications when the underlying container changes.

Fixes: #1422

…to match the visibility of observable_vector_base::call_changed to enabled derived classes to raise change notifications when the underlying container changes.
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennykerr kennykerr changed the title Changed visibility of observable_map_base::call_changed to protected … Changed visibility of observable_map_base::call_changed to protected Jul 11, 2024
@kennykerr kennykerr merged commit 4834e60 into microsoft:master Jul 11, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: observable_map_base::call_changed is private
2 participants