Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: observable_map_base::call_changed is private #1422

Closed
Patschkowski opened this issue Jul 6, 2024 · 4 comments · Fixed by #1425
Closed

Bug: observable_map_base::call_changed is private #1422

Patschkowski opened this issue Jul 6, 2024 · 4 comments · Fixed by #1425

Comments

@Patschkowski
Copy link
Contributor

Version

C++/WinRT v2.0.220110.5

Summary

Dear all,

winrt::observable_vector_base::call_changed is declared protected, while winrt::observable_map_base::call_changed is declared private.

Propose to change the latter to the way it is declared in the former.

Kind regard,
Felix

Reproducible example

No response

Expected behavior

winrt::observable_map_base::call_changed should be possible to access from a derived class.

Actual behavior

Cannot access winrt::observable_map_base::call_changed from a derived class.

Additional comments

No response

@kennykerr
Copy link
Collaborator

@dunhor may be able to comment on visibility.

@dunhor
Copy link
Member

dunhor commented Jul 8, 2024

Going based off source history, it looks like call_changed has existed since the very first commits; I did not add them. That aside, I don't see any reason why call_changed can't be protected in both types.

@kennykerr
Copy link
Collaborator

Ah, I may have written that after all. 😊

@kennykerr
Copy link
Collaborator

Feel free to offer a contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants