enable nullable by default

.editorconfig

@@ -697,6 +697,12 @@ dotnet_diagnostic.CA1851.severity = suggestion
 # CA1861: Avoid constant arrays as arguments
 dotnet_diagnostic.CA1861.severity = suggestion
 
+# IDE0240: Nullable directive is redundant
+dotnet_diagnostic.IDE0240.severity = suggestion
+
+# IDE0241: Nullable directive is unnecessary
+dotnet_diagnostic.IDE0241.severity = suggestion
+
 # Workaround for https://github.com/dotnet/roslyn-analyzers/issues/5628
 [Program.cs]
 dotnet_diagnostic.ca1812.severity = none

Directory.Build.props

@@ -8,6 +8,7 @@
     <AnalysisLevel>latest</AnalysisLevel>
     <AnalysisMode>AllEnabledByDefault</AnalysisMode>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <PropertyGroup Label="Package">

src/Microsoft.ComponentDetection.Common/Column.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 public class Column

src/Microsoft.ComponentDetection.Common/CommandLineInvocationService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/ComponentComparer.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/ComponentStream.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.IO;

src/Microsoft.ComponentDetection.Common/ComponentStreamEnumerable.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/DependencyGraph/ComponentRecorder.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/DependencyGraph/DependencyGraph.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/DirectoryItemFacade.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/DirectoryItemFacadeOptimized.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/DockerService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/EnvironmentVariableService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/FastDirectoryWalkerFactory.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/FileUtilityService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/FileWritingService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/MatchedFile.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.IO;

src/Microsoft.ComponentDetection.Common/PathUtilityService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/PatternMatchingUtility.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/SafeFileEnumerable.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/SafeFileEnumerableFactory.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/TabularStringFormat.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/Telemetry/CommandLineTelemetryService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry;
 
 using System;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/BcdeExecutionTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 using System;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/CommandLineInvocationTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 using System;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DependencyGraphTranslationRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 using System;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DetectedComponentScopeRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 using System.Runtime.CompilerServices;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DetectorExecutionTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class DetectorExecutionTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DockerServiceImageExistsLocallyTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class DockerServiceImageExistsLocallyTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DockerServiceInspectImageTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class DockerServiceInspectImageTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DockerServiceSystemInfoTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class DockerServiceSystemInfoTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DockerServiceTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class DockerServiceTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/DockerServiceTryPullImageTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class DockerServiceTryPullImageTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/FailedParsingFileRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class FailedParsingFileRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/GoGraphTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class GoGraphTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/GoReplaceTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class GoReplaceTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/InvalidParseVersionTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class InvalidParseVersionTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LinuxContainerDetectorImageDetectionFailed.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LinuxContainerDetectorImageDetectionFailed : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LinuxContainerDetectorLayerAwareness.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LinuxContainerDetectorLayerAwareness : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LinuxContainerDetectorMissingRepoNameAndTagRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LinuxContainerDetectorMissingRepoNameAndTagRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LinuxContainerDetectorMissingVersion.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LinuxContainerDetectorMissingVersion : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LinuxContainerDetectorUnsupportedOs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LinuxContainerDetectorUnsupportedOs : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LinuxScannerSyftTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LinuxScannerSyftTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LinuxScannerTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LinuxScannerTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/LoadComponentDetectorsTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class LoadComponentDetectorsTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/NuGetProjectAssetsTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 using System;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/PipReportFailureTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class PipReportFailureTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/PipReportSkipTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class PipReportSkipTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/PipReportTypeTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class PipReportTypeTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/PypiFailureTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 using System.Net;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/PypiMaxRetriesReachedTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class PypiMaxRetriesReachedTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/PypiRetryTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 using System.Net;

src/Microsoft.ComponentDetection.Common/Telemetry/Records/RustCrateDetectorTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class RustCrateDetectorTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Telemetry/Records/RustGraphTelemetryRecord.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common.Telemetry.Records;
 
 public class RustGraphTelemetryRecord : BaseDetectionTelemetryRecord

src/Microsoft.ComponentDetection.Common/Utilities/StringUtilities.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/ContainerDetails.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/DefaultGraphScanResult.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using Newtonsoft.Json;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/DependencyGraph.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/DependencyGraphCollection.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/DependencyGraphWithMetadata.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/DependencyScope.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 /// <summary>Used to communicate Dependency Scope of Component.

src/Microsoft.ComponentDetection.Contracts/BcdeModels/Detector.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/DockerLayer.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 public class DockerLayer

src/Microsoft.ComponentDetection.Contracts/BcdeModels/LayerMappedLinuxComponents.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/ScanResult.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/ScannedComponent.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/BcdeModels/TypedComponentConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 using System;

src/Microsoft.ComponentDetection.Contracts/ConcurrentHashSet.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 using System.Collections;

src/Microsoft.ComponentDetection.Contracts/DetectedComponent.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Contracts/DetectorClass.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 /// <summary>Class of detector, the names of which are converted into categories for all default detectors.</summary>

src/Microsoft.ComponentDetection.Contracts/DockerReference.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 public enum DockerReferenceKind

src/Microsoft.ComponentDetection.Contracts/FileComponentDetector.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 using System;

src/Microsoft.ComponentDetection.Contracts/FileComponentDetectorWithCleanup.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 using System;

src/Microsoft.ComponentDetection.Contracts/ICommandLineInvocationService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 using System;

src/Microsoft.ComponentDetection.Contracts/IComponentDetector.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Contracts;
 
 using System.Collections.Generic;