Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests #646

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix e2e tests #646

merged 2 commits into from
Nov 21, 2023

Conversation

TaoChenOSU
Copy link
Collaborator

@TaoChenOSU TaoChenOSU commented Nov 21, 2023

Motivation and Context

Our scenario tests have been failing. Need to fix them!

Description

  1. Fix the currently failing tests.
  2. Enable the Github action when PRs are moved to the merge queue.

Note: The JIRA plugin is still not working correctly. Still investigating.

Contribution Checklist

@TaoChenOSU TaoChenOSU added webapp Pull requests that update Typescript code webapi Pull requests that update .net code regression Issues related to regressions in functionality labels Nov 21, 2023
@TaoChenOSU TaoChenOSU self-assigned this Nov 21, 2023
@github-actions github-actions bot added github actions Pull requests that update GitHub Actions code and removed webapi Pull requests that update .net code labels Nov 21, 2023
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Nov 21, 2023
Merged via the queue into microsoft:main with commit f0a4dd9 Nov 21, 2023
6 checks passed
@TaoChenOSU TaoChenOSU deleted the taochen/fix-e2e-tests branch November 21, 2023 17:15
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Our scenario tests have been failing. Need to fix them!

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
1. Fix the currently failing tests.
2. Enable the Github action when PRs are moved to the merge queue.

Note: The JIRA plugin is still not working correctly. Still
investigating.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Pull requests that update GitHub Actions code regression Issues related to regressions in functionality webapp Pull requests that update Typescript code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants