Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scenario tests #265

Merged

Conversation

TaoChenOSU
Copy link
Collaborator

Motivation and Context

Description

The scenario tests have been failing for a long time, due to rapid changes coming into the repo. It's time to fix them.

Contribution Checklist

  1. Skip Jira plugin test since we don't have a managed account.
  2. Fix all other tests.

Will create an item to track the GitHub and Jira plugin tests.

@TaoChenOSU TaoChenOSU self-assigned this Aug 28, 2023
@github-actions github-actions bot added the webapp Pull requests that update Typescript code label Aug 28, 2023
@github-actions github-actions bot added the github actions Pull requests that update GitHub Actions code label Aug 28, 2023
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Aug 28, 2023
Merged via the queue into microsoft:main with commit d04040c Aug 28, 2023
6 checks passed
@TaoChenOSU TaoChenOSU deleted the users/taochen/fix-scenario_tests branch August 28, 2023 22:20
@TaoChenOSU TaoChenOSU mentioned this pull request Aug 30, 2023
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the copilot-chat repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

The scenario tests have been failing for a long time, due to rapid
changes coming into the repo. It's time to fix them.

### Contribution Checklist
1. Skip Jira plugin test since we don't have a managed account.
2. Fix all other tests.

Will create an item to track the GitHub and Jira plugin tests.

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github actions Pull requests that update GitHub Actions code webapp Pull requests that update Typescript code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants