render chat messages as markdown #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
|
@microsoft-github-policy-service agree |
crickman
requested review from
teresaqhoang,
dehoward,
glahaye,
alliscode and
gitri-ms
and removed request for
teresaqhoang
crickman
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
I like it. Love the removal of convertToAnchorTags.
Do we want to run this through function testing? @teresaqhoang ?
(Nice profile icon @Rainson12 🥇 )
alliscode
approved these changes
Aug 29, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Description When requesting `generate a table of fruits` or `generate some code to count from 1 to 200` the response will contain markdown:  However Markdown can not be rendered in the frontend. This PR fixes it by adding a markdown rendering library and making use of it:  This also avoids using `dangerouslySetInnerHTML` attribute. The library `remark-gfm` is used because `react-markdown` does not support tables out of the box. This is how urls or links would be rendered: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When requesting
generate a table of fruitsorgenerate some code to count from 1 to 200the response will contain markdown:However Markdown can not be rendered in the frontend. This PR fixes it by adding a markdown rendering library and making use of it:
This also avoids using
dangerouslySetInnerHTMLattribute. The libraryremark-gfmis used becausereact-markdowndoes not support tables out of the box.This is how urls or links would be rendered:
