Delete Chat #193
Merged
Delete Chat #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
webapp
alliscode
requested changes
Aug 16, 2023
alliscode
previously requested changes
Aug 16, 2023
glahaye
reviewed
Aug 16, 2023
alliscode
reviewed
Aug 18, 2023
TaoChenOSU
reviewed
Aug 18, 2023
gitri-ms
reviewed
Aug 21, 2023
gitri-ms
requested changes
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
previously approved these changes
Aug 21, 2023
TaoChenOSU
approved these changes
Aug 22, 2023
gitri-ms
approved these changes
Aug 22, 2023
teresaqhoang
dismissed
alliscode’s stale review
Discussed offline and got sign-off after I addressed his last comments. Ben's oof now for the week, don't want to block
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR enables chat deletion. For V1, any user is able to delete any chat they're a part of. This will delete the chat for all participants, including Chat Copilot, as well as all related resources (memories, messages, etc.). ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> When a chat is deleted, - It will be immediately removed for the user who initiated the deletion. <img width="1234" alt="Screenshot 2023-08-16 at 5 54 46 PM" src="https://github.com/microsoft/chat-copilot/assets/125500434/7fb8a2e7-c70f-44e2-9e35-91bbe9e3f810"> - If the chat was a multi-user chat, the chat will be disabled in current session. This allows other participants to save any resources before the chat is wiped out. On refresh, chat is removed from list. <img width="1680" alt="Screenshot 2023-08-16 at 5 54 35 PM" src="https://github.com/microsoft/chat-copilot/assets/125500434/5ac2c7d3-f11a-4575-8d8a-5fe2bdb5aba7"> <img width="429" alt="Screenshot 2023-08-16 at 5 54 58 PM" src="https://github.com/microsoft/chat-copilot/assets/125500434/f1bedd1a-7801-406a-8263-2965f67e5a39"> - If the chat was the last chat in the user's current session, a new chat will automatically be created to populate the chat list. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations ~~- [ ] All unit tests pass, and I have added new tests where possible~~ - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR enables chat deletion. For V1, any user is able to delete any chat they're a part of. This will delete the chat for all participants, including Chat Copilot, as well as all related resources (memories, messages, etc.).
Description
When a chat is deleted,
Contribution Checklist
- [ ] All unit tests pass, and I have added new tests where possible