Encapsulate signalR hub connection instance #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
added
bug
glahaye
previously approved these changes
Aug 9, 2023
teresaqhoang
previously approved these changes
Aug 10, 2023
TaoChenOSU
added
PR: ready to merge
alliscode
previously approved these changes
Aug 10, 2023
dehoward
reviewed
Aug 10, 2023
webapp/src/redux/features/message-relay/signalRHubConnection.ts
Outdated
Show resolved
Hide resolved
dehoward
previously approved these changes
Aug 10, 2023
TaoChenOSU
dismissed stale reviews from dehoward, alliscode, teresaqhoang, and glahaye
via
78d6d94
glahaye
approved these changes
Aug 17, 2023
TaoChenOSU
deleted the
taochen/feature-encapsulate-signal-r-hub-connection
branch
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> The app currently attempts to establish the Signal R connection before validating the environment file. If the .env file is missing, the app won't be able to establish the signal R connection since it needs the backend URL. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Delay the attempt to establish the signal R connection to only when the connection is needed. This allows the error of a missing/incorrect .env file to be shown. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The app currently attempts to establish the Signal R connection before validating the environment file. If the .env file is missing,
the app won't be able to establish the signal R connection since it needs the backend URL.
Description
Delay the attempt to establish the signal R connection to only when the connection is needed. This allows the error of a missing/incorrect .env file to be shown.
Contribution Checklist