Fix race condition in the creation of scoped kernels #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b586b8.
glahaye
added
bug
Closed
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context Calling Build() on a Kernel builder causes an update to the list of DI services. Those services are also iterated over in Build(). Since the code only had one copy of the list of services, multiple simultaneous calls to Build() could modify the list while it was being iterated over, causing the bug described at microsoft#916 ### Description Instead of calling Build for each instance of a kernel desired, we now create a single kernel and clone it when a new instance is desired. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
### Motivation and Context Calling Build() on a Kernel builder causes an update to the list of DI services. Those services are also iterated over in Build(). Since the code only had one copy of the list of services, multiple simultaneous calls to Build() could modify the list while it was being iterated over, causing the bug described at microsoft#916 ### Description Instead of calling Build for each instance of a kernel desired, we now create a single kernel and clone it when a new instance is desired. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Calling Build() on a Kernel builder causes an update to the list of DI services. Those services are also iterated over in Build(). Since the code only had one copy of the list of services, multiple simultaneous calls to Build() could modify the list while it was being iterated over, causing the bug described at #916
Description
Instead of calling Build for each instance of a kernel desired, we now create a single kernel and clone it when a new instance is desired.
Contribution Checklist