Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin skprompt.txt files not being copied to output directory during release builds #701

Open
eamon-keane opened this issue Dec 7, 2023 · 1 comment
Open

Plugin skprompt.txt files not being copied to output directory during release builds #701

eamon-keane opened this issue Dec 7, 2023 · 1 comment
Labels
deployment Issues related to deploying Chat-Copilot documentation Improvements or additions to documentation .NET Pull requests that update .net code webapi Pull requests that update .net code

Comments

@eamon-keane
Copy link
Contributor

eamon-keane commented Dec 7, 2023 •
edited
Loading

Describe the bug
When packaging the the build, skprompt.txt files are not being copied to output directory. When deploying the build to Azure, the required files aren't present for the plugins.

To Reproduce
Steps to reproduce the behavior:

  1. run package-webapi.ps1
  2. View webapi.zip artifact (unzip if needed)
  3. Plugin skprompt.txt files not present in plugins directory

Expected behavior
Expect to see skprompt.txt files in publish artifact

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • OS: Windows
  • IDE: Visual Studio
  • Language:C#,
  • Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]

Additional context
Properties of the skprompt.txt files can be changed in project file to include them in output directory:
<None Update="Plugins\SemanticPlugins\WriterPlugin\BriefingParagraph\skprompt.txt"> <CopyToOutputDirectory>Always</CopyToOutputDirectory> </None> <Content Include="Plugins\SemanticPlugins\*.*"> <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> </Content>
Instructions here could be updated to make it clear that if you want to publish the plugins using this method the properties
https://github.com/microsoft/chat-copilot/blob/main/webapi/README.md
@crickman
Copy link
Contributor

Thank you for pointing this out. I agree this should be made more clear in the readme.

@crickman crickman added documentation Improvements or additions to documentation webapi Pull requests that update .net code deployment Issues related to deploying Chat-Copilot .NET Pull requests that update .net code labels Dec 13, 2023
@crickman crickman self-assigned this Dec 13, 2023
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2024
@eamon-keane
Issue #701 updated readme.md for webapi to make it clearer how one ca…
536fb43 
…n include plugins in build output for publishing (#752)

### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required? Issue #701 
2. What problem does it solve? Not clear in readme that this step is
needed in order to publish plugins
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here. #701 
-->

### Description

Readme updated with example of what is required to include prompt.txt in
build output
@crickman crickman removed their assignment Feb 28, 2024
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this issue Oct 7, 2024
@eamon-keane
Issue microsoft#701 updated readme.md for webapi to make it clearer h…
7e9630c 
…ow one can include plugins in build output for publishing (microsoft#752)

### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required? Issue microsoft#701 
2. What problem does it solve? Not clear in readme that this step is
needed in order to publish plugins
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here. microsoft#701 
-->

### Description

Readme updated with example of what is required to include prompt.txt in
build output
kb0039 pushed a commit to aaronba/chat-copilot that referenced this issue Jan 8, 2025
@eamon-keane
Issue microsoft#701 updated readme.md for webapi to make it clearer h…
15ff78e 
…ow one can include plugins in build output for publishing (microsoft#752)

### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required? Issue microsoft#701 
2. What problem does it solve? Not clear in readme that this step is
needed in order to publish plugins
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here. microsoft#701 
-->

### Description

Readme updated with example of what is required to include prompt.txt in
build output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployment Issues related to deploying Chat-Copilot documentation Improvements or additions to documentation .NET Pull requests that update .net code webapi Pull requests that update .net code
Projects
No open projects
Apps & Services Semantic Kernel
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamon-keane @crickman