Skip to content

Commit

Permalink
Updating broken links and links to wrong repository. (#278)
Browse files Browse the repository at this point in the history
### Description

Fixing broken links and links that point to the wrong repository.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Ben Thomas <[email protected]>
  • Loading branch information
alliscode and Ben Thomas authored Aug 30, 2023
1 parent 5b8c252 commit d0d92bb
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 26 deletions.
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### Motivation and Context

<!-- Thank you for your contribution to the copilot-chat repo!
<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following information:
1. Why is this change required?
2. What problem does it solve?
Expand All @@ -18,6 +18,6 @@ Please help reviewers and future users, providing the following information:
<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations
- [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone :smile:
3 changes: 0 additions & 3 deletions .github/workflows/markdown-link-check-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
},
{
"pattern": "^https://localhost"
},
{
"pattern": "https://github.com/microsoft/copilot-chat/releases"
}
],
"timeout": "20s",
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ tips on how you can make reporting your issue as effective as possible.

### Where to Report

New issues can be reported in our [list of issues](https://github.com/microsoft/copilot-chat/issues).
New issues can be reported in our [list of issues](https://github.com/microsoft/chat-copilot/issues).

Before filing a new issue, please search the list of issues to make sure it does
not already exist.
Expand Down Expand Up @@ -91,7 +91,7 @@ We use and recommend the following workflow:
"issue-123" or "githubhandle-issue".
4. Make and commit your changes to your branch.
5. Add new tests corresponding to your change, if applicable.
6. Run the relevant scripts in [the section below](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#dev-scripts) to ensure that your build is clean and all tests are passing.
6. Run the relevant scripts in [the section below](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#dev-scripts) to ensure that your build is clean and all tests are passing.
7. Create a PR against the repository's **main** branch.
- State in the description what issue or improvement your change is addressing.
- Verify that all the Continuous Integration checks are passing.
Expand Down
43 changes: 24 additions & 19 deletions scripts/deploy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,49 +45,54 @@ You will need two Azure Active Directory (AAD) application registrations -- one
- Make a note of the `Application (client) ID` from the Azure Portal for use in the `Deploy Azure infrastructure` step below.

### Linking the frontend to the backend

1. Expose an API within the backend app registration
1. Select *Expose an API* from the menu

2. Add an *Application ID URI*
1. Select _Expose an API_ from the menu

2. Add an _Application ID URI_

1. This will generate an `api://` URI

2. Click *Save* to store the generated URI
2. Click _Save_ to store the generated URI

3. Add a scope for `access_as_user`
1. Click *Add scope*

2. Set *Scope name* to `access_as_user`
1. Click _Add scope_

2. Set _Scope name_ to `access_as_user`

3. Set *Who can consent* to *Admins and users*
3. Set _Who can consent_ to _Admins and users_

4. Set *Admin consent display name* and *User consent display name* to `Access Chat Copilot as a user`
4. Set _Admin consent display name_ and _User consent display name_ to `Access Chat Copilot as a user`

5. Set *Admin consent description* and *User consent description* to `Allows the accesses to the Chat Copilot web API as a user`
5. Set _Admin consent description_ and _User consent description_ to `Allows the accesses to the Chat Copilot web API as a user`

4. Add the web app frontend as an authorized client application
1. Click *Add a client application*

2. For *Client ID*, enter the frontend's application (client) ID
1. Click _Add a client application_

3. Check the checkbox under *Authorized scopes*
2. For _Client ID_, enter the frontend's application (client) ID

4. Click *Add application*
3. Check the checkbox under _Authorized scopes_

4. Click _Add application_

2. Add permissions to web app frontend to access web api as user

4. Add permissions to web app frontend to access web api as user
1. Open app registration for web app frontend

2. Go to *API Permissions*
2. Go to _API Permissions_

3. Click *Add a permission*
3. Click _Add a permission_

4. Select the tab *My APIs*
4. Select the tab _APIs my organization uses_

5. Choose the app registration representing the web api backend

6. Select permissions `access_as_user`

7. Click *Add permissions*

7. Click _Add permissions_

# Deploy Azure Infrastructure

Expand Down Expand Up @@ -120,7 +125,7 @@ You can also deploy the infrastructure directly from the Azure Portal by clickin

[![Deploy to Azure](https://aka.ms/deploytoazurebutton)](https://aka.ms/sk-deploy-existing-azureopenai-portal)

> This will automatically deploy the most recent release of CopilotChat backend binaries ([link](https://github.com/microsoft/copilot-chat/releases)).
> This will automatically deploy the most recent release of CopilotChat backend binaries ([link](https://github.com/microsoft/chat-copilot/releases)).
> To find the deployment name when using `Deploy to Azure`, look for a deployment in your resource group that starts with `Microsoft.Template`.
Expand Down

0 comments on commit d0d92bb

Please sign in to comment.