Skip to content

Commit

Permalink
Update Dockerfile.nginx (#269)
Browse files Browse the repository at this point in the history
### Description
webapp/Dockerfile.nginx flag needs to have --production=false otherwise
react-scripts won't be installed to build the webapp

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
  • Loading branch information
huangyingting authored Aug 29, 2023
1 parent d767c02 commit c47fe32
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docker/webapp/Dockerfile.nginx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RUN yarn install \
--prefer-offline \
--frozen-lockfile \
--non-interactive \
--production=true
--production=false

RUN yarn build

Expand All @@ -31,4 +31,4 @@ FROM nginx:stable-alpine
EXPOSE 3000
RUN sed -i 's/80/3000/g' /etc/nginx/conf.d/default.conf
COPY --from=builder /app/build /usr/share/nginx/html
CMD ["nginx", "-g", "daemon off;"]
CMD ["nginx", "-g", "daemon off;"]

0 comments on commit c47fe32

Please sign in to comment.