refactor: Extract messages to the properties bundle #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <[email protected]>
| @@ -61,8 +62,7 @@ public SourcesResult getBuildTargetSources(SourcesParams params) { | |||
| for (BuildTargetIdentifier btId : params.getTargets()) { | |||
| GradleBuildTarget target = buildTargetManager.getGradleBuildTarget(btId); | |||
| if (target == null) { | |||
| logger.warn("Skip sources collection for the build target: {}" | |||
| + "because it cannot be found in the cache.", btId.getUri()); | |||
| logger.warn(MessageUtils.get("warning.skipBuildTargetSources"), btId.getUri()); | |||
There was a problem hiding this comment.
it's log message, not UI message. I don't think nls is needed for them.
There was a problem hiding this comment.
It depends. For example, in the future, we can have a log appender that append the log to the client via BSP notification like OnBuildLogMessage, where users can see it.
On the other hand, if we are sure that no need to translate those log messages. We can simply ignore them in other language bundle files. The JVM will be fallback to the default if it does not exist.
Signed-off-by: Sheng Chen <[email protected]>
akaroml
reviewed
Jul 20, 2023
| @@ -0,0 +1,7 @@ | |||
| error.serverStorageMissing=The property 'buildServerStorage' is not set. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.