Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test gradle.properties jvm args are used #178

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Arthurm1
Copy link
Contributor

@Arthurm1 Arthurm1 commented Aug 1, 2024

Adds a test case to check that jvmargs in gradle.properties are respected.

It's possible to set jvm args at various points of the tooling api. This checks they're being set in the ProjectConnection. If the tooling API spins off another process to retrieve the model and that doesn't use the same jvm args, then that wouldn't be tested for here.

Uses BuildEnvironment to check jvm args.

@jdneo
Copy link
Member

jdneo commented Aug 1, 2024

So it turns out the jvm args are picked by gradle?

@jdneo
Copy link
Member

jdneo commented Aug 1, 2024

@timreebow Could you share more information? Or is there any other way that we can leverage for testing?

@Arthurm1
Copy link
Contributor Author

Arthurm1 commented Aug 1, 2024

So it turns out the jvm args are picked by gradle?

It seems so. gradle/gradle#22856 seems to back that up it but also suggests that there is a priority order so I did wonder if they were being overwritten somewhere rather than not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants