Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - --no-daemon not working on Gradle 8.9 #172

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix - --no-daemon not working on Gradle 8.9 #172

merged 1 commit into from
Jul 16, 2024

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Jul 15, 2024

--no-daemon is not supported by gradle 8.9. You will get

UnsupportedBuildArgumentException@13 "org.gradle.tooling.exceptions.UnsupportedBuildArgumentException: Could not fetch model of type 'BuildEnvironment' using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.9-bin.zip'.
Problem with provided build arguments: [--no-daemon]. 
Unknown command-line option '--no-daemon'.
Either it is not a valid build option or it is not supported in the target Gradle version.
Not all of the Gradle command line options are supported build arguments.
Examples of supported build arguments: '--info', '-p'.
Examples of unsupported build options: '--daemon', '-?', '-v'.
Please find more information in the javadoc for the BuildLauncher class."

On the other hand, getting BuildEnvironment won't invoke a new gradle daemon actually, looks like the tooling api directly handles it

fix microsoft/vscode-gradle#1519

@jdneo jdneo added this to the 0.3.0 milestone Jul 15, 2024
@jdneo jdneo added the bug Something isn't working label Jul 15, 2024
@testforstephen
Copy link

Why is this no longer supported? Is there another way to specify 'no daemon'?

@jdneo
Copy link
Member Author

jdneo commented Jul 16, 2024

--no-daemon does not take any effect actually. It won't spawn any gradle daemon process when getting the BuildEnvironment model from my observation

@jdneo jdneo merged commit 189e7f0 into develop Jul 16, 2024
4 checks passed
@jdneo jdneo deleted the cs/no-daemon branch July 16, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build server crashes with Gradle v8.9
2 participants