fix - Use project dir instead of project path

[jdneo]

• In composite build scenario, the project path is not based on the build tree root. Besides, the .getBuildTreePath() is not available before Gradle 8.3, we use the project dir to identify a Gradle project instead. The project dir is used in dependency resolution.

Fix the point 2 in #154 (comment)

[jdneo]

// cc @Tanish-Ranjan, @Arthurm1

[Arthurm1]

So project.getPath() is not unique when using included builds? We might need to also look at what goes into gradleSourceSet.setDisplayName. It might be better to do in the action after full retrieval. Maybe set display name to full path and then pare it down to differences in the build action?
I did something similar here. I can look to reproduce in another PR?

[jdneo]

So project.getPath() is not unique when using included builds?

No they are not. In the sample project that I referenced, both project path is :.

It might be better to do in the action after full retrieval. Maybe set display name to full path and then pare it down to differences in the build action?
I did something similar here. I can look to reproduce in another PR?

Sure, feel free to address it in another PR if you want :)

[Tanish-Ranjan]

So project.getPath() is not unique when using included builds?

It won't. Any information that comes from the project will be stripped down to the rootProject. SourceSetsModelBuilder considers the project it receives in the buildAll parameter, to be the root project. This is why we had to resort to BuildActions in #154, as it contains the complete information of the project hierarchy. It queries for each sub project in the build. This is where the SourceSetsModelBuilder starts building the requested model unaware of the entire project hierarchy and thinks the sub project we are querying is actually the root project.

Now because of the way model builders work we cannot rely on hierarchical information from it, such as project path.

Hope I explained it well. Please ask any questions if you have queries.

[jdneo]

Another solution is to get the build tree path by casting the Project to DefaultProject, and call getIdentityPath(). But that is an internal API, and since the project dir works fine for now, we can use project dir currently.

Just to share this information in case we need to revisit this problem in the future.