Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remaining ESLint issues #4846

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: Remaining ESLint issues #4846

merged 2 commits into from
Jan 21, 2025

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the remaining ESLint issues.

Specific Changes

  • Added conditional ESLint rules for the repo tools.
  • Removed remaining only-warn rules and fixed small ESLint issues.

Testing

The following image shows the lint command running without problems
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner January 16, 2025 13:51
@tracyboehrer tracyboehrer merged commit 7b1434f into main Jan 21, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/remaining-eslint branch January 21, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sw-joelmut @tracyboehrer