Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MeetingTabIconSurface to MeetingSurface capabilities #4459

Merged
merged 2 commits into from
May 3, 2023

Conversation

corinagum
Copy link
Collaborator

@corinagum corinagum commented Apr 21, 2023

fixes #4458

Description

Add-on to Meeting Notifications feature, where tab icons can push a notification to alert specified users in the UBar

Specific Changes

  • Add new interface MeetingTabIconSurface to teams
  • Turn MeetingSurface into union type: MeetingStageSurface<any> | MeetingTabIconSurface
  • Add to tests that using MeetingTabIcon payload

Testing

  • Unit tests updated
  • Manual testing was successful. Different scenarios below:
    • 200: Sending TabIcon to hardcoded sender's user id: returns 200 with empty payload
      image
      image
    • Success when recipient is just a hardcoded member string: (same as above)
    • 207: Partial success where one of two member id's are invalid: Payload indicates the failure and reason.
      image
      image
  • When recipient array is empty:
    image

FE Test container: https://teams.microsoft.com/multi-window/?container=20230421193-oncdn-ba26868c

image

@corinagum corinagum requested a review from a team as a code owner April 21, 2023 19:50
@coveralls
Copy link

coveralls commented Apr 21, 2023

Pull Request Test Coverage Report for Build 4768648640

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.653%

Totals Coverage Status
Change from base Build 4198805038: -0.003%
Covered Lines: 20013
Relevant Lines: 22404

💛 - Coveralls

@corinagum corinagum assigned corinagum and tracyboehrer and unassigned corinagum Apr 21, 2023
@tracyboehrer tracyboehrer merged commit 561d438 into main May 3, 2023
@tracyboehrer tracyboehrer deleted the corinagum/visual-notifications branch May 3, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend MeetingSurfaceNotification to include TabIcon
5 participants