fix: [#4449] CloudAdapter always builds Connector with MicrosoftAppCredentials (never CertificateAppCredentials) -- certificate auth flow broken #4457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4449
Description
This PR adds support for the CloudAdapter's configuration process to authenticate using certificates is MultiTenant and SingleTenant apps.
Specific Changes
CertificateServiceClientCredentialsFactory
class, to instantiate and configure theCertificateAppCredentials
class, so the process knows how to authenticate with certificates.ConfigurationServiceClientCredentialFactory
unit tests, validating the different code paths when using certificates.CertificateThumbprint
andCertificatePrivateKey
constants to theAuthenticationConstants
,ConfigurationBotFrameworkAuthentication
andConfigurationServiceClientCredentialFactory
classes.ConfigurationServiceClientCredentialFactory
to detect when a certificate is provided, and execute the proper functionality to authenticate with certificates (instead of a password) in MultiTenant and SingleTenant apps.Testing
The following images show the bot and unit tests working as expected.

