Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4370] Update @azure/cognitiveservices-luis-runtime > @azure/ms-rest-js library #4378

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4370

Description

This PR updates the @azure/ms-rest-js library inside the @azure/cognitiveservices-luis-runtime dependency, from 1.6.0 to 2.6.1, so the uuid library is upgraded from the version 3.4.0 to 8.3.2 (the warning message is also removed).

Note: upgrading the uuid from the version 3 to 8 alone wasn't possible due to deprecated imports (more information).

Specific Changes

  • Added a new resolutions' field at the root package.json file, upgrading the ms-rest-js version to 2.6.1.
  • Updated yarn.lock file with the updated ms-rest-js version.

Testing

The following image shows the core-bot working as expected in both version (v2, v3) with the changes.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner December 2, 2022 18:58
@coveralls
Copy link

coveralls commented Dec 2, 2022

Pull Request Test Coverage Report for Build 3707575950

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.633%

Totals Coverage Status
Change from base Build 3707438925: -0.003%
Covered Lines: 19968
Relevant Lines: 22357

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit bdb736e into main Dec 15, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/botbuilder-ai-ms-rest-js branch December 15, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade packages
3 participants