fix: [#4314] CloudAdapter: messages are not sorted correctly #4322
+36
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3045290854
💛 - Coveralls |
tracyboehrer
approved these changes
Sep 13, 2022
tracyboehrer
deleted the
southworks/fix/cloudadapter-send-activities-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4314
Description
This PR fixes an issue where multiple message activities were sent in different orders using WebChat or Emulator.
The problem was in the sendActivities method, where the activities were processed in parallel, and thus sent in different order.
To solve this issue, we basically ported the functionality changes from DotNet's SendActivities implementation.
Specific Changes
maptofor of, so activities are processed sequentially and not in parallel.Testing
The following image shows the comparison between the actual and expected behavior.
