Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#5837] Fix sentiment values not being set for None / Unknown intent (#6348) #4275

Merged
merged 3 commits into from
Jul 13, 2022
Merged

port: [#5837] Fix sentiment values not being set for None / Unknown intent (#6348) #4275

merged 3 commits into from
Jul 13, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4261

Description

This PR ports the changes from PR#6348 to include the sentiment properties into the RecognizerResult when the None intent is triggered.

Specific Changes

  • Added sentiment properties for None intents in:
    • botbuilder-dialogs-adaptive/recognizers/crossTrainedRecognizerSet.ts
    • botbuilder-dialogs/recognizer.ts
  • Added unit tests in crossTrainedRecognizerSet.test.js to cover the new code.
  • Added botbuilder as dev-dependency for the new tests.

Testing

These images show the bot trace with the sentiment block and the new tests passing.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner July 8, 2022 19:22
@coveralls
Copy link

coveralls commented Jul 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2665587564

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 84.485%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 2665580777: 0.004%
Covered Lines: 19903
Relevant Lines: 22311
💛 - Coveralls

@tracyboehrer
Copy link
Member

@ceciliaavila Can you take a look at the conflict?

@tracyboehrer tracyboehrer merged commit 0cd28d8 into main Jul 13, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/set-sentiment-none-intents branch July 13, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: [#5837] Fix sentiment values not being set for None / Unknown intent (#6348)
3 participants
@ceciliaavila @coveralls @tracyboehrer