fix: [#4204] Fix remaining eslint warnings - botbuilder-core (2/2)

[ceciliaavila]

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-core library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separate task as they require deeper analysis and testing.

Specific Changes

• Applied auto-fixes with yarn lint --fix
  • Fix spacing.
  • Fix indentation.
  • Fix quoting.
  • Replace arrow functions: () => with function ().
  • Replace let with const.
• Applied manual fixes for:
  • Unused parameters and imports.
  • Replacing hasOwnProperty calls.
  • Removing unused test class BotStateMock in botStateSet.test.js.
• Removed unused lodash devDependency.

Testing

Here we can see the eslint status before and after.

[coveralls]

Pull Request Test Coverage Report for Build 2258581646

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.003%) to 84.48%

---

Totals
Change from base Build 2245574340:	-0.003%
Covered Lines:	19902
Relevant Lines:	22310

---

💛 - Coveralls