New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#4044] Add obsolete attribute to BotFrameworkHttpAdapter and related classes. (#6096) #4168

Merged

gabog merged 3 commits into main from southworks/update/mark-obsolete-botframeworkhttpadapter

Mar 21, 2022

Collaborator

ceciliaavila commented Mar 18, 2022

Fixes #4044

Description

This PR adds the @deprecated attribute to BotFrameworkHttpAdapter and related classes, in order to migrate to CloudAdapter.
[BotBuilder-DotNet's PR#6096](https://github.com/microsoft/botbuilder-dotnet/pull/ 6096) was taken as a base.

Specific Changes

Added the @deprecated attribute to the following classes:
- botFrameworkAdapter
- botFrameworkAdapterSettings
- botFrameworkHttpAdapter
- botFrameworkHttpClient
- channelServiceHandler
- skillHandler
- channelValidation
- SimplecredentialProvider
- ICredentialProvider
- emulatorValidation
- enterpriseChannelValidation
- governmentChannelValidation
- jwtTokenValidation
- skillValidation
Updated botbuilder.api.md documentation

Testing

This image shows the build passing after the changes.

ceciliaavila added 3 commits

March 15, 2022 17:22


          Add @deprecated to botFrameworkHttpAdapter classes

2cb9712


          Update botbuilder.api documentation

7160ac2


          Fix lint issues

a4bc3ec

ceciliaavila requested a review from a team as a code owner

March 18, 2022 19:12

coveralls commented Mar 18, 2022 •

edited

Loading

Pull Request Test Coverage Report for Build 2005978708

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 84.473%

Totals
Change from base Build 2001351852:	-0.003%
Covered Lines:	19731
Relevant Lines:	22123

💛 - Coveralls

gabog approved these changes

View reviewed changes

gabog merged commit 860d8a9 into main

gabog deleted the southworks/update/mark-obsolete-botframeworkhttpadapter branch

March 21, 2022 21:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet