Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4064][#6019] Remove redundant project dependencies from AI Recognizers (#6067) #4152

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4064

Description

This PR moves redundant dependencies out of the dependencies section to the peerDependencies or devDependencies sections depending on the case.

Note: If we remove the dependencies, although the build and the tests work, the depcheck command fails with the 'missing dependency' error.

Specific Changes

  • botbuilder-ai-orchestrator
    • Moved botbuilder-dialogs-declarative and botbuilder-dialogs-adaptive-runtime-core under peerDependencies as they are included in botbuilder-dialogs-adaptive.
    • Moved adaptive-expressions, botbuilder-core, and botbuilder-dialogs under devDependencies as they are required by the tests.
  • botbuilder-ai
    • Moved adaptive-expressions, botbuilder-core, and botbuilder-dialogs under devDependencies as they are required by the tests.
  • botbuilder-dialogs-adaptive
    • Moved adaptive-expressions, botbuilder, and botbuilder-dialogs under devDependencies as they are required by the tests.
  • botbuilder-dialogs-declarative
    • Moved botbuilder-core under devDependencies as they are required by the tests.

Testing

This image shows an extract of the console running the depcheck command with no issues.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner March 9, 2022 20:39
@coveralls
Copy link

coveralls commented Mar 9, 2022

Pull Request Test Coverage Report for Build 1986647262

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.561%

Totals Coverage Status
Change from base Build 1971383171: -0.003%
Covered Lines: 19671
Relevant Lines: 22037

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 492c3d8 into main Mar 17, 2022
@mrivera-ms mrivera-ms deleted the southworks/update/redundant-dependencies branch March 17, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: [#6019] Remove redundant project dependencies from AI Recognizers (#6067)
3 participants