Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4144] TeamsInfo.sendMessageToTeamsChannel() doesn't return the correct ConversationReference #4145

Merged

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4144
#minor

Description

This PR fixes an issue when calling the TeamsInfo.sendMessageToTeamsChannel method and reply to the new message thread, it replies to the first message sent to the bot instead of the new created one.
DotNet's reference

Specific Changes

  • Updated TurnContext.getConversationReference execution to get the ConversationReference from the turnContext instead of the original context.

Testing

The following images show the bot working as expected after the applied fix.
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner March 4, 2022 17:40
@coveralls
Copy link

coveralls commented Mar 4, 2022

Pull Request Test Coverage Report for Build 1971215040

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.555%

Totals Coverage Status
Change from base Build 1971162915: -0.003%
Covered Lines: 19672
Relevant Lines: 22040

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 5c4a3aa into main Mar 11, 2022
@mrivera-ms mrivera-ms deleted the southworks/fix/message-teams-channel-conversation-reference branch March 11, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: TeamsInfo.sendMessageToTeamsChannel() doesn't return the correct ConversationReference
3 participants