Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump adal-node for xmldom CVE #3929

Merged
merged 1 commit into from
Sep 17, 2021
Merged

chore: bump adal-node for xmldom CVE #3929

merged 1 commit into from
Sep 17, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Sep 17, 2021

adal-node published 0.2.3 which moves to @xmldom/xmldom as a CVE resolution.

#minor

@mdrichardson
Copy link
Contributor

I can't seem to start a Review, but LGTM, unless we also want to bump it here: https://github.com/microsoft/botbuilder-js/blob/6fab548c8ade620a7eb3d8905729ff6cd0649237/tools/framework/suite-base.js

But that's only used for tests, so might not matter.

@joshgummersall
Copy link
Contributor Author

Yeah, not a concern IMO as we don't publish that package anywhere.

@coveralls
Copy link

coveralls commented Sep 17, 2021

Pull Request Test Coverage Report for Build 1247140862

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.543%

Totals Coverage Status
Change from base Build 1231612568: -0.003%
Covered Lines: 19635
Relevant Lines: 21998

💛 - Coveralls

@stevengum stevengum merged commit f42c967 into main Sep 17, 2021
@stevengum stevengum deleted the jpg/bump-adal-node branch September 17, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants