fix: Bug in orchestratorRecognizer.ts InitializeModel #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed bug in initializemodel
tsuwandy
changed the title
hcyang
reviewed
Jul 2, 2021
There was a problem hiding this comment.
if (this.scoreEntities) {
if (!orchestrator.load(fullModelFolder, entityModelFolder)) {
throw new Error(
`Model load failed - model folder ${fullModelFolder}, entity model folder ${entityModelFolder}.`
);
}
} else {
if (!orchestrator.load(fullModelFolder)) {
throw new Error(`Model load failed - model folder ${fullModelFolder}.`);
}
}
if load with entity model fail, the no need to fall back to intent only
hcyang
approved these changes
Jul 2, 2021
Pull Request Test Coverage Report for Build 992050406
💛 - Coveralls |
| ); | ||
| } else if (!orchestrator.load(fullModelFolder)) { | ||
| throw new Error(`Model load failed - model folder ${fullModelFolder}.`); | ||
| if (this.scoreEntities) { |
There was a problem hiding this comment.
Can you add a test for this?
joshgummersall
approved these changes
Jul 2, 2021
joshgummersall
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Update orchestratorRecognizer.ts fixed bug in initializemodel * Update orchestratorRecognizer.ts if load with entity model fail, the no need to fall back to intent only
joshgummersall
pushed a commit
that referenced
this pull request
Jul 2, 2021
* fix: Bug in orchestratorRecognizer.ts InitializeModel (#3842) * Update orchestratorRecognizer.ts fixed bug in initializemodel * Update orchestratorRecognizer.ts if load with entity model fail, the no need to fall back to intent only * port: runtime docs (#3838) * port: runtime docs Fixes #3809 Also adds some types to ServiceCollection calls * spellcheck! Co-authored-by: Michael Richardson <[email protected]> Co-authored-by: Michael Richardson <[email protected]> Co-authored-by: Tien Suwandy <[email protected]> Co-authored-by: Michael Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3841