Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use BFAuthentication for BFClient in runtime, fix comparison bug #3820

Merged
merged 2 commits into from
Jun 26, 2021
Merged

chore: use BFAuthentication for BFClient in runtime, fix comparison bug #3820

merged 2 commits into from
Jun 26, 2021

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Jun 25, 2021 •
edited
Loading

#minor

Description

  • Removes SkillHttpClient node from Adaptive runtime in favor of BotFrameworkAuthentication.createBotFrameworkClient() (AdaptiveDialogBot in .NET)
    • The addSkills() method is now more aligned with .NET's implementation (AddBotRuntimeSkills())
    • Also removes SkillHttpCllient dependency ICredentialProvider from Adaptive runtime
    • Ran code formatter in botbuilder-dialogs-adaptive-runtime/src/index.ts
  • Fixes comparison issue in PasswordServiceClientCredentialFactory.create()

Testing

Tested with Skills on US Gov Cloud.

@stevengum stevengum requested a review from joshgummersall June 25, 2021 23:37
@stevengum stevengum requested review from a team as code owners June 25, 2021 23:37
@stevengum stevengum requested a review from luhan2017 June 25, 2021 23:37
joshgummersall
joshgummersall approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid cleanup! Nice find on the comparison issue.

@stevengum stevengum merged commit 24a7d5f into main Jun 26, 2021
@stevengum stevengum deleted the stgum/runtime branch June 26, 2021 00:24
@coveralls
Copy link

coveralls commented Jun 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 973020208

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 83.725%
Totals Coverage Status
Change from base Build 972962999: 0.01%
Covered Lines: 19503
Relevant Lines: 22069
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @joshgummersall