feat: create conversation

[joshgummersall]

Fixes #3752

[coveralls]

Pull Request Test Coverage Report for Build 969180472

• 1 of 24 (4.17%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.09%) to 83.711%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/botbuilder-core/src/botAdapter.ts	0	1	0.0%
libraries/botbuilder-core/src/cloudAdapterBase.ts	1	23	4.35%

Totals
Change from base Build 968813841:	-0.09%
Covered Lines:	19497
Relevant Lines:	22065

---

💛 - Coveralls

[stevengum]

Are the applicable Teams flows functional with these changes?

[stevengum]

I would expect that at this point, the claimsIdentity would have an audienceClaim with the value of audience, not the botAppId:

botbuilder-js/libraries/botbuilder-core/src/cloudAdapterBase.ts

Lines 307 to 315 in 0db8231

	return new ClaimsIdentity([
	{
	type: AuthenticationConstants.AudienceClaim,
	value: botAppId,
	},
	{
	type: AuthenticationConstants.AppIdClaim,
	value: botAppId,
	},

Is there a reason this isn't the case?

What will happen is that the ClaimsIdentity is essentially Emulator-esque as the appId and audience claim are the same value (the botAppId), whereas the created ConnectorClient is properly addressed to the passed in audience. This audience will can be a channel, another bot, or something else entirely.

[joshgummersall]

Not sure, I followed John's lead in porting this. As far as I can tell, this is equivalent to .NET. Perhaps we should file an issue on .NET?

[joshgummersall]

Working on testing in Teams.

EDIT: @stevengum, I was able to successfully call createConversationAsync and send an activity to myself in Teams.

[stevengum]

Approved, let's follow up on the proper claims construction in the .NET repo