Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OAuth prompt should store in turn.token, not dialog.token #3803

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

mdrichardson
Copy link
Contributor

Fixes #3797

Note: The .NET PR also replaces this for TestBot, but we don't have that or anything like it (particularly, the testbot.schema file), so the JS port gets 2 of the 3 changes.

image

image
image
image

@mdrichardson mdrichardson requested review from chrimc62, tomlm and a team as code owners June 24, 2021 17:14
@coveralls
Copy link

coveralls commented Jun 24, 2021

Pull Request Test Coverage Report for Build 968779132

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 83.796%

Totals Coverage Status
Change from base Build 968725555: -0.4%
Covered Lines: 19496
Relevant Lines: 22041

💛 - Coveralls

@mdrichardson mdrichardson merged commit 0db8231 into microsoft:main Jun 24, 2021
@mdrichardson mdrichardson deleted the oAuthTokenTurn branch June 24, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Fix OAuth prompt should store in turn.token, not dialog.token (#5693)
3 participants