Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning on component load failure #3780

Merged
merged 1 commit into from
Jun 19, 2021
Merged

fix: warning on component load failure #3780

merged 1 commit into from
Jun 19, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3766

@joshgummersall joshgummersall requested review from a team as code owners June 18, 2021 23:51
@coveralls
Copy link

coveralls commented Jun 19, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 951396193

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 85.415%
Totals Coverage Status
Change from base Build 951375279: -0.003%
Covered Lines: 19303
Relevant Lines: 21499
💛 - Coveralls

@joshgummersall joshgummersall merged commit fec4bfe into main Jun 19, 2021
@joshgummersall joshgummersall deleted the jpg/load-component-warning branch June 19, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log warning when no bot component definitions returned by referenced packages
3 participants
@joshgummersall @coveralls @mdrichardson