Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Maxturn count increase while interruption in composer prompts #3774

Merged
merged 1 commit into from
Jun 18, 2021
Merged

port: Maxturn count increase while interruption in composer prompts #3774

merged 1 commit into from
Jun 18, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3773

Description

The turn count would increase only turn.interrupte is set to false.

@Danieladu Danieladu requested review from a team as code owners June 18, 2021 06:19
@Danieladu Danieladu requested review from chrimc62 and luhan2017 June 18, 2021 06:19
@coveralls
Copy link

coveralls commented Jun 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 948900170

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 85.408%
Totals Coverage Status
Change from base Build 943670693: -0.002%
Covered Lines: 19274
Relevant Lines: 21468
💛 - Coveralls

@joshgummersall joshgummersall merged commit cb2145b into main Jun 18, 2021
@joshgummersall joshgummersall deleted the hond/maxturn branch June 18, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: fix: Maxturn count increase while interruption in composer prompts (#5690)
3 participants
@Danieladu @coveralls @joshgummersall